[Top] [All Lists]

Re: [PATCH 25/25] xfs: add write verifiers to log recovery

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 25/25] xfs: add write verifiers to log recovery
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 30 Oct 2012 08:23:31 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20121026203107.GJ29378@dastard>
References: <1351146854-19343-1-git-send-email-david@xxxxxxxxxxxxx> <1351146854-19343-26-git-send-email-david@xxxxxxxxxxxxx> <20121026085448.GD3035@xxxxxxxxxxxxx> <20121026203107.GJ29378@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
> Remote attr buffers aren't logged - they are written sycnhronously
> during the transaction - so won't get found by this.

Oh right.  Removing the synchronous writes for the remote attrs is
someting we should tackled on day as well.

> As for remote
> symlink buffers, yeah, that might be a problem. Ultimately, both of
> these buffer types are going to grow headers for CRCs, so this
> problem will go away. I'm not sure how to address this problem
> in the mean time short of putting the buffer content type into all
> the buf_log_format headers. Do you have any better ideas?

I can't think of a really good idea.  But introducing user exploitable
issues in log recovery is something I'd avoid.  I also hate having to
change the log format now if we're going to bump it soon again.  Let
me look a bit more at the log recovery code if there's some way to
interfer the buffer type.

<Prev in Thread] Current Thread [Next in Thread>