xfs
[Top] [All Lists]

Re: [PATCH 01/25] xfs: growfs: don't read garbage for new secondary supe

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 01/25] xfs: growfs: don't read garbage for new secondary superblocks
From: Phil White <pwhite@xxxxxxx>
Date: Mon, 29 Oct 2012 17:17:50 -0700
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1351146854-19343-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1351146854-19343-1-git-send-email-david@xxxxxxxxxxxxx> <1351146854-19343-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 25, 2012 at 05:33:50PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When updating new secondary superblocks in a growfs operation, the
> sueprblock buffer is read from the newly grown region of the
> underlying device. This is not guaranteed to be zero, so violates
> the underlying assumption that the unused parts of superblocks are
> zero filled. Get a new buffer for these secondary superblocks to
> ensure that the unused regions are zero filled correctly.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> ---
> [ snip ]

Looks good to me too. 

Reviewed-by: Phil White <pwhite@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>