xfs
[Top] [All Lists]

Re: [PATCH 14/25] xfs: verify dir2 block format buffers

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 14/25] xfs: verify dir2 block format buffers
From: Phil White <pwhite@xxxxxxx>
Date: Mon, 29 Oct 2012 20:26:19 -0700
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1351146854-19343-15-git-send-email-david@xxxxxxxxxxxxx>
References: <1351146854-19343-1-git-send-email-david@xxxxxxxxxxxxx> <1351146854-19343-15-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 25, 2012 at 05:34:03PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Add a dir2 block format read verifier. To fully verify every block
> when read, call xfs_dir2_data_check() on them. Change
> xfs_dir2_data_check() to do runtime checking, convert ASSERT()
> checks to XFS_WANT_CORRUPTED_RETURN(), which will trigger an ASSERT
> failure on debug kernels, but on production kernels will dump an
> error to dmesg and return EFSCORRUPTED to the caller.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Solid.

Reviewed-by: Phil White <pwhite@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>