| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 08/25] xfs: verify AGFL blocks as they are read from disk |
| From: | Phil White <pwhite@xxxxxxx> |
| Date: | Mon, 29 Oct 2012 18:00:28 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1351146854-19343-9-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1351146854-19343-1-git-send-email-david@xxxxxxxxxxxxx> <1351146854-19343-9-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Oct 25, 2012 at 05:33:57PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Add an AGFL block verify callback function and pass it into the > buffer read functions. > > While this commit adds verification code to the AGFL, it cannot be > used reliably until the CRC format change comes along as mkfs does > not initialise the full AGFL. Hence it can be full of garbage at the > first mount and will fail verification right now. CRC enabled > filesystems won't have this problem, so leave the code that has > already been written ifdef'd out until the proper time. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > --- > fs/xfs/xfs_alloc.c | 40 +++++++++++++++++++++++++++++++++++++++- > 1 file changed, 39 insertions(+), 1 deletion(-) Okee doke by me. Reviewed-by: Phil White <pwhite@xxxxxxx> |
| Previous by Date: | Re: [PATCH 11/25] xfs: verify dquot blocks as they are read from disk, Phil White |
|---|---|
| Next by Date: | Re: [PATCH 09/25] xfs: verify inode buffers as they are read from disk, Phil White |
| Previous by Thread: | [PATCH 08/25] xfs: verify AGFL blocks as they are read from disk, Dave Chinner |
| Next by Thread: | [PATCH 17/25] xfs: factor dir2 leaf read, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |