Re: [PATCH 11/25] xfs: verify dquot blocks as they are read from disk

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 11/25] xfs: verify dquot blocks as they are read from disk
From:	Phil White <pwhite@xxxxxxx>
Date:	Mon, 29 Oct 2012 18:36:54 -0700
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1351146854-19343-12-git-send-email-david@xxxxxxxxxxxxx>
References:	<1351146854-19343-1-git-send-email-david@xxxxxxxxxxxxx> <1351146854-19343-12-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Thu, Oct 25, 2012 at 05:34:00PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Add a dquot buffer verify callback function and pass it into the
> buffer read functions. This checks all the dquots in a buffer, but
> cannot completely verify the dquot ids are correct. Also, errors
> cannot be repaired, so an additional function is added to repair bad
> dquots in the buffer if such an error is detected in a context where
> repair is allowed.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.

Reviewed-by: Phil White <pwhite@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 01/25] xfs: growfs: don't read garbage for new secondary superblocks, (continued) [PATCH 01/25] xfs: growfs: don't read garbage for new secondary superblocks, Dave Chinner Re: [PATCH 01/25] xfs: growfs: don't read garbage for new secondary superblocks, Phil White [PATCH 09/25] xfs: verify inode buffers as they are read from disk, Dave Chinner Re: [PATCH 09/25] xfs: verify inode buffers as they are read from disk, Phil White [PATCH 05/25] xfs: verify superblocks as they are read from disk, Dave Chinner Re: [PATCH 05/25] xfs: verify superblocks as they are read from disk, Phil White [PATCH 07/25] xfs: verify AGI blocks as they are read from disk, Dave Chinner Re: [PATCH 07/25] xfs: verify AGI blocks as they are read from disk, Phil White Re: [PATCH 07/25] xfs: verify AGI blocks as they are read from disk, Dave Chinner [PATCH 11/25] xfs: verify dquot blocks as they are read from disk, Dave Chinner Re: [PATCH 11/25] xfs: verify dquot blocks as they are read from disk, Phil White <= [PATCH 14/25] xfs: verify dir2 block format buffers, Dave Chinner Re: [PATCH 14/25] xfs: verify dir2 block format buffers, Phil White [PATCH 13/25] xfs: factor dir2 block read operations, Dave Chinner Re: [PATCH 13/25] xfs: factor dir2 block read operations, Phil White Re: [PATCH 13/25] xfs: factor dir2 block read operations, Dave Chinner [PATCH 19/25] xfs: add xfs_da_node verification, Dave Chinner Re: [PATCH 19/25] xfs: add xfs_da_node verification, Phil White Re: [PATCH 19/25] xfs: add xfs_da_node verification, Dave Chinner Re: [PATCH 19/25] xfs: add xfs_da_node verification, Phil White Re: [PATCH 19/25] xfs: add xfs_da_node verification, Dave Chinner

Previous by Date:	Re: [PATCH 13/25] xfs: factor dir2 block read operations, Phil White
Next by Date:	Re: [PATCH 08/25] xfs: verify AGFL blocks as they are read from disk, Phil White
Previous by Thread:	[PATCH 11/25] xfs: verify dquot blocks as they are read from disk, Dave Chinner
Next by Thread:	[PATCH 14/25] xfs: verify dir2 block format buffers, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]