Re: [PATCH 15/25] xfs: factor dir2 free block reading

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 15/25] xfs: factor dir2 free block reading
From:	Phil White <pwhite@xxxxxxx>
Date:	Tue, 30 Oct 2012 06:14:20 -0700
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1351146854-19343-16-git-send-email-david@xxxxxxxxxxxxx>
References:	<1351146854-19343-1-git-send-email-david@xxxxxxxxxxxxx> <1351146854-19343-16-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Thu, Oct 25, 2012 at 05:34:04PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Also factor out the updating of the free block when removing entries
> from leaf blocks, and add a verifier callback for reads.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_dir2_leaf.c |    3 +-
>  fs/xfs/xfs_dir2_node.c |  218 
> +++++++++++++++++++++++++++++++-----------------
>  fs/xfs/xfs_dir2_priv.h |    2 +
>  3 files changed, 143 insertions(+), 80 deletions(-)

Looks like good work to me.

Reviewed-by: Phil White <pwhite@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 06/25] xfs: verify AGF blocks as they are read from disk, (continued) [PATCH 06/25] xfs: verify AGF blocks as they are read from disk, Dave Chinner Re: [PATCH 06/25] xfs: verify AGF blocks as they are read from disk, Phil White [PATCH 18/25] xfs: factor and verify attr leaf reads, Dave Chinner Re: [PATCH 18/25] xfs: factor and verify attr leaf reads, Phil White [PATCH 12/25] xfs: add verifier callback to directory read code, Dave Chinner Re: [PATCH 12/25] xfs: add verifier callback to directory read code, Phil White [PATCH 23/25] xfs: connect up write verifiers to new buffers, Dave Chinner Re: [PATCH 23/25] xfs: connect up write verifiers to new buffers, Phil White Re: [PATCH 23/25] xfs: connect up write verifiers to new buffers, Dave Chinner [PATCH 15/25] xfs: factor dir2 free block reading, Dave Chinner Re: [PATCH 15/25] xfs: factor dir2 free block reading, Phil White <= [PATCH 21/25] xfs: add buffer pre-write callback, Dave Chinner Re: [PATCH 21/25] xfs: add buffer pre-write callback, Christoph Hellwig Re: [PATCH 21/25] xfs: add buffer pre-write callback, Dave Chinner Re: [PATCH 21/25] xfs: add buffer pre-write callback, Christoph Hellwig Re: [PATCH 21/25] xfs: add buffer pre-write callback, Phil White [PATCH 25/25] xfs: add write verifiers to log recovery, Dave Chinner Re: [PATCH 25/25] xfs: add write verifiers to log recovery, Christoph Hellwig Re: [PATCH 25/25] xfs: add write verifiers to log recovery, Dave Chinner Re: [PATCH 25/25] xfs: add write verifiers to log recovery, Christoph Hellwig Re: [PATCH 25/25] xfs: add write verifiers to log recovery, Dave Chinner

Previous by Date:	Re: [PATCH 18/25] xfs: factor and verify attr leaf reads, Phil White
Next by Date:	Re: [PATCH 16/25] xfs: factor out dir2 data block reading, Phil White
Previous by Thread:	[PATCH 15/25] xfs: factor dir2 free block reading, Dave Chinner
Next by Thread:	[PATCH 21/25] xfs: add buffer pre-write callback, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]