xfs
[Top] [All Lists]

Re: [PATCH 16/25] xfs: factor out dir2 data block reading

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 16/25] xfs: factor out dir2 data block reading
From: Phil White <pwhite@xxxxxxx>
Date: Tue, 30 Oct 2012 06:21:37 -0700
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1351146854-19343-17-git-send-email-david@xxxxxxxxxxxxx>
References: <1351146854-19343-1-git-send-email-david@xxxxxxxxxxxxx> <1351146854-19343-17-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 25, 2012 at 05:34:05PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> And add a verifier callback function while there.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_dir2_block.c |    3 +--
>  fs/xfs/xfs_dir2_data.c  |   32 ++++++++++++++++++++++++++++++++
>  fs/xfs/xfs_dir2_leaf.c  |   38 +++++++++++++++++---------------------
>  fs/xfs/xfs_dir2_node.c  |    8 ++++----
>  fs/xfs/xfs_dir2_priv.h  |    2 ++
>  5 files changed, 56 insertions(+), 27 deletions(-)
 
This one actually made a little light bulb go off.  I'd been wondering
why you conjoined logical conditions in an assignment to block_ok
earlier, but split things out here.  I see now that it's to explicitly
and unambiguosly separate out the order of evaluation.

Reviewed-by: Phil White <pwhite@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>