Re: [PATCH 16/25] xfs: factor out dir2 data block reading

[Phil White <pwhite@xxxxxxx>]

On Thu, Oct 25, 2012 at 05:34:05PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> And add a verifier callback function while there.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_dir2_block.c |    3 +--
>  fs/xfs/xfs_dir2_data.c  |   32 ++++++++++++++++++++++++++++++++
>  fs/xfs/xfs_dir2_leaf.c  |   38 +++++++++++++++++---------------------
>  fs/xfs/xfs_dir2_node.c  |    8 ++++----
>  fs/xfs/xfs_dir2_priv.h  |    2 ++
>  5 files changed, 56 insertions(+), 27 deletions(-)
 
This one actually made a little light bulb go off.  I'd been wondering
why you conjoined logical conditions in an assignment to block_ok
earlier, but split things out here.  I see now that it's to explicitly
and unambiguosly separate out the order of evaluation.

Reviewed-by: Phil White <pwhite@xxxxxxx>