xfs
[Top] [All Lists]

Re: [PATCH 22/25] xfs: add pre-write metadata buffer verifier callbacks

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 22/25] xfs: add pre-write metadata buffer verifier callbacks
From: Phil White <pwhite@xxxxxxx>
Date: Tue, 30 Oct 2012 06:34:46 -0700
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1351146854-19343-23-git-send-email-david@xxxxxxxxxxxxx>
References: <1351146854-19343-1-git-send-email-david@xxxxxxxxxxxxx> <1351146854-19343-23-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 25, 2012 at 05:34:11PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> These verifiers are essentially the same code as the read verifiers,
> but do not require ioend processing. Hence factor the read verifier
> functions and add a new write verifier wrapper that is used as the
> callback.
> 
> This is done as one large patch for all verifiers rather than one
> patch per verifier as the change is largely mechanical. This
> includes hooking up the write verifier via the read verifier
> function.
> 
> Hooking up the write verifier for buffers obtained via
> xfs_trans_get_buf() will be done in a separate patch as that touches
> code in many different places rather than just the verifier
> functions.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_alloc.c        |   38 +++++++++++++++++++++++++++++++++-----
>  fs/xfs/xfs_alloc_btree.c  |   21 +++++++++++++++++----
>  fs/xfs/xfs_attr_leaf.c    |   19 +++++++++++++++++--
>  fs/xfs/xfs_attr_leaf.h    |    2 +-
>  fs/xfs/xfs_bmap_btree.c   |   21 +++++++++++++++++----
>  fs/xfs/xfs_da_btree.c     |   30 ++++++++++++++++++------------
>  fs/xfs/xfs_dir2_block.c   |   16 +++++++++++++++-
>  fs/xfs/xfs_dir2_data.c    |   19 +++++++++++++++++--
>  fs/xfs/xfs_dir2_leaf.c    |   31 ++++++++++++++++++++++++-------
>  fs/xfs/xfs_dir2_node.c    |   17 ++++++++++++++++-
>  fs/xfs/xfs_dir2_priv.h    |    2 +-
>  fs/xfs/xfs_dquot.c        |   22 ++++++++++++++++++----
>  fs/xfs/xfs_ialloc.c       |   17 ++++++++++++++++-
>  fs/xfs/xfs_ialloc_btree.c |   19 ++++++++++++++++---
>  fs/xfs/xfs_inode.c        |   19 +++++++++++++++++--
>  fs/xfs/xfs_inode.h        |    2 +-
>  fs/xfs/xfs_itable.c       |    2 +-
>  fs/xfs/xfs_mount.c        |   19 +++++++++++++++++--
>  18 files changed, 262 insertions(+), 54 deletions(-)

Looks OK by me.

Reviewed-by: Phil White <pwhite@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>