[Top] [All Lists]

Re: [PATCH 21/25] xfs: add buffer pre-write callback

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 21/25] xfs: add buffer pre-write callback
From: Phil White <pwhite@xxxxxxx>
Date: Tue, 30 Oct 2012 06:32:18 -0700
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1351146854-19343-22-git-send-email-david@xxxxxxxxxxxxx>
References: <1351146854-19343-1-git-send-email-david@xxxxxxxxxxxxx> <1351146854-19343-22-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 25, 2012 at 05:34:10PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> Add a callback to the buffer write path to enable verification of
> the buffer and CRC calculation prior to issuing the write to the
> underlying storage.
> If the callback function detects some kind of failure or error
> condition, it must mark the buffer with an error so that the caller
> can take appropriate action. In the case of xfs_buf_ioapply(), a
> corrupt metadta buffer willt rigger a shutdown of the filesystem,
> because something is clearly wrong and we can't allow corrupt
> metadata to be written to disk.
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Reviewed-by: Phil White <pwhite@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>