[Top] [All Lists]

Re: xfstests: test ext4 statfs

To: <xfs@xxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>, ext4 development <linux-ext4@xxxxxxxxxxxxxxx>
Subject: Re: xfstests: test ext4 statfs
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Mon, 29 Oct 2012 09:12:26 -0500
In-reply-to: <508E8480.5020507@xxxxxxx>
References: <5089749C.4050003@xxxxxxxxxx> <508AD066.4090102@xxxxxxx> <508AD8E8.1040301@xxxxxxxxxx> <508E8480.5020507@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
  xfstests: test ext4 statfs

    Calculating free blocks in ext[234] is surprisingly hard, since
    by default we report "bsd" style df which doesn't count filesystem
    "overhead" blocks as used.

    With a lot of code dedicated to sorting out what to report as
    free, things tend to go wrong surprisingly often.

    Here's a test to actually try to stop the next regression.  ;)

    NB: For bsddf, the kernel currently does not count journal blocks
    as overhead; it probably should.  But the test below looks to have
    the result within 1% of perfection, so it still passes even if
    the kernel doesn't count the journal against free blocks.


This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit 0b2ab695.


<Prev in Thread] Current Thread [Next in Thread>