xfs
[Top] [All Lists]

Re: xfstests: resolve symlinked devices to real paths

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: xfstests: resolve symlinked devices to real paths
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Fri, 26 Oct 2012 11:46:45 -0500
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <4C0EA21B.8020703@xxxxxxxxxxx>
References: <4C0EA21B.8020703@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
On 06/08/2010 03:03 PM, Eric Sandeen wrote:
If you try running xfstests on lvm volumes which are symlinks,
it'll fail to run several tests because our _require_scratch
framework ultimately uses lstat not stat, and does not think
the lvm device (which is usually a symlink to a dm-X device)
is a block device.  Sigh.

Last try at this - just resolve any symlinked devicenames
into their realpath(3) in common.config.

This actually seems to work.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

---


diff --git a/common.config b/common.config
index 926846b..e5b2483 100644
--- a/common.config
+++ b/common.config

Looks good

Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>

Eric,

This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.

Thanks
--Rich

<Prev in Thread] Current Thread [Next in Thread>
  • Re: xfstests: resolve symlinked devices to real paths, Rich Johnston <=