xfs
[Top] [All Lists]

Re: [PATCH] xfs: silence uninitialised f.file warning.

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: silence uninitialised f.file warning.
From: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Date: Fri, 26 Oct 2012 11:40:38 -0200
Cc: xfs@xxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx
In-reply-to: <1351146150-19113-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1351146150-19113-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 25, 2012 at 05:22:30PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Uninitialised variable build warning introduced by 2903ff0 ("switch
> simple cases of fget_light to fdget"), gcc is not smart enough to
> work out that the variable is not used uninitialised, and the commit
> removed the initialisation at declaration that the old variable had.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_ioctl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
> index 8305f2a..c1df3c6 100644
> --- a/fs/xfs/xfs_ioctl.c
> +++ b/fs/xfs/xfs_ioctl.c
> @@ -70,7 +70,7 @@ xfs_find_handle(
>       int                     hsize;
>       xfs_handle_t            handle;
>       struct inode            *inode;
> -     struct fd               f;
> +     struct fd               f = {0};
>       struct path             path;
>       int                     error;
>       struct xfs_inode        *ip;
> -- 
> 1.7.10
> 
Looks good,

Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
-- 
--Carlos

<Prev in Thread] Current Thread [Next in Thread>