xfs
[Top] [All Lists]

Re: [PATCH 02/25] xfs: invalidate allocbt blocks moved to the free list

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 02/25] xfs: invalidate allocbt blocks moved to the free list
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 26 Oct 2012 04:47:29 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1351146854-19343-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1351146854-19343-1-git-send-email-david@xxxxxxxxxxxxx> <1351146854-19343-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> index f1647ca..f7876c6 100644
> --- a/fs/xfs/xfs_alloc_btree.c
> +++ b/fs/xfs/xfs_alloc_btree.c
> @@ -121,6 +121,8 @@ xfs_allocbt_free_block(
>       xfs_extent_busy_insert(cur->bc_tp, be32_to_cpu(agf->agf_seqno), bno, 1,
>                             XFS_EXTENT_BUSY_SKIP_DISCARD);
>       xfs_trans_agbtree_delta(cur->bc_tp, -1);
> +
> +     xfs_trans_binval(cur->bc_tp, bp);
>       return 0;

I'd be almost tempted to move this into the caller, as the bmap and
ialloc btrees do it and I always wondered how the alloc btree got away
without it.

Otherwise looks ok,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>