xfs
[Top] [All Lists]

[PATCH] xfs: Remove redundant return error from xfs_difree()

To: xfs@xxxxxxxxxxx
Subject: [PATCH] xfs: Remove redundant return error from xfs_difree()
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Thu, 25 Oct 2012 12:28:05 +0800
Organization: Oracle
Reply-to: jeff.liu@xxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20
If we can not fetch the related a.g. info when freeing a disk inode, it mostly 
like a
fatal issue was occurred and with ASSERT(0) is fine, however, return 
XFS_ERROR(EINVAL)
does not make sense here.

Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>

---
 fs/xfs/xfs_ialloc.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/fs/xfs/xfs_ialloc.c b/fs/xfs/xfs_ialloc.c
index 445bf1a..b7ea965 100644
--- a/fs/xfs/xfs_ialloc.c
+++ b/fs/xfs/xfs_ialloc.c
@@ -1065,7 +1065,6 @@ xfs_difree(
                xfs_warn(mp, "%s: agno >= mp->m_sb.sb_agcount (%d >= %d).",
                        __func__, agno, mp->m_sb.sb_agcount);
                ASSERT(0);
-               return XFS_ERROR(EINVAL);
        }
        agino = XFS_INO_TO_AGINO(mp, inode);
        if (inode != XFS_AGINO_TO_INO(mp, agno, agino))  {
@@ -1073,14 +1072,12 @@ xfs_difree(
                        __func__, (unsigned long long)inode,
                        (unsigned long long)XFS_AGINO_TO_INO(mp, agno, agino));
                ASSERT(0);
-               return XFS_ERROR(EINVAL);
        }
        agbno = XFS_AGINO_TO_AGBNO(mp, agino);
        if (agbno >= mp->m_sb.sb_agblocks)  {
                xfs_warn(mp, "%s: agbno >= mp->m_sb.sb_agblocks (%d >= %d).",
                        __func__, agbno, mp->m_sb.sb_agblocks);
                ASSERT(0);
-               return XFS_ERROR(EINVAL);
        }
        /*
         * Get the allocation group header.
-- 
1.7.4.1

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] xfs: Remove redundant return error from xfs_difree(), Jeff Liu <=