xfs
[Top] [All Lists]

Re: [PATCH v6] Stop periodic syncing if filesystem is already shutdown.

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH v6] Stop periodic syncing if filesystem is already shutdown.
From: Raghavendra Prabhu <raghu.prabhu13@xxxxxxxxx>
Date: Thu, 25 Oct 2012 02:27:31 +0530
Cc: david@xxxxxxxxxxxxx, Raghavendra D Prabhu <rprabhu@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=an6IqpqMbsentc8vVF1A+noGjmreCrXc/hxt0iBEJyA=; b=M24g5BxHRXTD2uAsB2GxC+BQUXC7kzKQbr1qp0pa79o+9dHvaZ8QUv4B83SQpl42r0 4X8La2UJc5cMJb1P7b3A4PXknChsRRdwNTu6zVDt8BN3ZIEmlEom/80JTUTe+NQiB/vp VJL1/eX5l+rXu8u5/08HRJP4Y6txzusAyM0AT7bbS4JMcveHPwKxlg+Z802c4dsCkHxT a0rXYoV9If5JvQC4LlGMteAK5bhNAGP1Z50HqMRT3OR3fGAPg97ZUQG5x6dygCLIlz/j UPDvMSjs+wGtMtvYHbUZZ7lc/iIPP84+LHxNIogj9SeaWJpfc5SN8Knn8vbstKE6LFLr 5h3Q==
In-reply-to: <20120925094013.GI9189@xxxxxxxxxxxxx>
References: <143becf0f8266fbc8025ec97c8f44476d8fcafc5.1348203015.git.rprabhu@xxxxxxxxxxx> <20120925094013.GI9189@xxxxxxxxxxxxx>
Thank you. Are there any comments on this patch or has is it been acked?

On Tue, Sep 25, 2012 at 3:10 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> Looks good, but one thing I'd love here is to actually print a useful
> error for the typical EIO case, as the "error 5 occured" message just
> confuses the heck out of people.  What it means is that we got an
> EIO error from the block device, and that's what we should print.
>
> Probably worth doing in a separate patch, so:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>