xfs
[Top] [All Lists]

Re: [PATCH v3 0/3] Print when ENOSPC due to lack of inodes.

To: xfs@xxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH v3 0/3] Print when ENOSPC due to lack of inodes.
From: Raghavendra Prabhu <raghu.prabhu13@xxxxxxxxx>
Date: Thu, 25 Oct 2012 02:26:02 +0530
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=1K5Zw1zhZ3vcxR5vdo0JTP4kFIC/q+mBpQyYwpdF4Ck=; b=csE2JPSF2SYgDm1NSZX/bGSLdelLNykYrRKG+C7EH8SNxWteRLK5kuu394RBD448W1 6Ai6e90QaeFfu0NpqsYFHFpjZdY4aIQEaokcRYXquvCzX45ykDXJ4/8NmMqsqGw8CByz HotL+TOJ7d3Y5qUsk3g0ZaQRtOpJvsuPM26Dmvvk4/otkmsAdytX3+S3i2OQ0iLutlmv NNrrLODtHS20SqPJDrQKwNKl5iJedlr5PQ3rKeYH2qSfseyUQ9p/jJ7EQxzmuT4i7hs7 nGm1Vbdj0dCs850nrzTYGWzmXySfBzCAKwg4DFDe04pnnR2Xjgua6Bftx7vE98uGmh1W RLDw==
In-reply-to: <cover.1348639531.git.rprabhu@xxxxxxxxxxx>
References: <cover.1348639531.git.rprabhu@xxxxxxxxxxx>
Hi,

Checking back on this, whether it has been reviewed and if so, any comments.

On Wed, Sep 26, 2012 at 12:26 PM,  <raghu.prabhu13@xxxxxxxxx> wrote:
> From: Raghavendra D Prabhu <rprabhu@xxxxxxxxxxx>
>
> Currently, when there are no free inodes left / free space to allocate them 
> (usually
> without inode64), there is no indication anywhere of this case, making it 
> harder
> to diagnose this case.
>
> Hence, this series prints the causes/reasons to kernel log in a ratelimited
> manner, when such a situation arises.
>
> Regarding why it is printed at callee location instead at caller, it gives
> greater granularity in expressing the precise reason and give more details, 
> and
> also some along the path are not ENOSPC (such in xfs_ialloc where 
> ialloc_context is not NULL but
> ino is) along with the fact that it (xfs_ialloc) is called at multiple sites, 
> so to avoid duplication.
>
> Version 1: Initial series.
> Version 2: Added ratelimited printing to xfs_message and used that.
> Version 3: Kept the logic intact in few places, fixed the column requirement.
>
> Raghavendra D Prabhu (3):
>   xfs: Add ratelimited printk for different alert levels
>   xfs: Print error when xfs_ialloc_ag_select fails to find continuous
>     free space.
>   xfs: Print error when unable to allocate inodes or out of free
>     inodes.
>
>  fs/xfs/xfs_ialloc.c  | 31 ++++++++++++++++++++++++++++---
>  fs/xfs/xfs_linux.h   |  1 +
>  fs/xfs/xfs_message.h | 26 ++++++++++++++++++++++++++
>  3 files changed, 55 insertions(+), 3 deletions(-)
>
> --
> 1.7.12.1
>

<Prev in Thread] Current Thread [Next in Thread>