xfs
[Top] [All Lists]

Re: [PATCH 1/2] 286: Test FITRIM where length is smaller than FSB

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] 286: Test FITRIM where length is smaller than FSB
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Wed, 24 Oct 2012 15:44:25 -0500
Cc: Lukas Czerner <lczerner@xxxxxxxxxx>, <xfs@xxxxxxxxxxx>
In-reply-to: <50885216.1020201@xxxxxxx>
References: <1350380494-17482-1-git-send-email-lczerner@xxxxxxxxxx> <20121016201645.GJ2739@dastard> <50885216.1020201@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
On 10/24/2012 03:39 PM, Rich Johnston wrote:
Lukas,

On 10/16/2012 03:16 PM, Dave Chinner wrote:
On Tue, Oct 16, 2012 at 11:41:33AM +0200, Lukas Czerner wrote:
This tests corner case in FITRIM implementation where range size is
smaller than file system block or zero. In this case FITRIM should fail
with EINVAL.

The problem was spotted in xfs and ext4 where in case of length = 0 the
'end' variable underflowed. In case of length smaller than 1 FSB FITRIM
finished successfully, but we really should rather return EINVAL in both
cases.

(This patch has to be applied after 'Use upstream version of fstrim
instead of the local one')

Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
---
  286     |   58
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  286.out |    6 ++++++

We've already got 286 (and 287), so this should probably be 288...

Otherwise, it looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>


This has been committed to git://oss.sgi.com/xfs/xfs.git, master and
for-next branches.

Regards
--Rich

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs

My apologies, this has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master and for-next branches.

Regards
--Rich

<Prev in Thread] Current Thread [Next in Thread>