xfs
[Top] [All Lists]

Re: [PATCH 2/2] 251: Do not allow step to be zero

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] 251: Do not allow step to be zero
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Wed, 24 Oct 2012 15:43:04 -0500
Cc: Lukas Czerner <lczerner@xxxxxxxxxx>, <xfs@xxxxxxxxxxx>
In-reply-to: <20121016201829.GK2739@dastard>
References: <1350380494-17482-1-git-send-email-lczerner@xxxxxxxxxx> <1350380494-17482-2-git-send-email-lczerner@xxxxxxxxxx> <20121016201829.GK2739@dastard>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
Lukas,

On 10/16/2012 03:18 PM, Dave Chinner wrote:
On Tue, Oct 16, 2012 at 11:41:34AM +0200, Lukas Czerner wrote:
Currently 'step' variable which is used as length of the range to
discard can be zero. However it would result in error returned by the
fstrim.

Fix this by forcing 'step' to be at least 4KB.

Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>

Looks fine. It may not be perfect for large block filesystems (e.g.
on ppc or ia64) but it's better than nothing right now.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>


This has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master and for-next branches.

Regards
--Rich

<Prev in Thread] Current Thread [Next in Thread>