xfs
[Top] [All Lists]

Re: [PATCH 24/23] xfs: convert buffer verifiers to an ops structure.

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 24/23] xfs: convert buffer verifiers to an ops structure.
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 23 Oct 2012 08:36:47 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20121018045028.GQ2739@dastard>
References: <1350020669-19504-1-git-send-email-david@xxxxxxxxxxxxx> <1350020669-19504-23-git-send-email-david@xxxxxxxxxxxxx> <20121013160212.GA24337@xxxxxxxxxxxxx> <20121014001219.GR2739@dastard> <20121018045028.GQ2739@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 18, 2012 at 03:50:28PM +1100, Dave Chinner wrote:
> Here's a patch that does this. It adds on top of the series, and
> points out more changes needed to growfs to support CRC checking
> properly.

I like this a lot, and I'm fine with having this at the end of the
series if it makes your life easier.

> -xfs_agfl_write_verify(
> +xfs_agfl_read_verify(
>       struct xfs_buf  *bp)
>  {
>       xfs_agfl_verify(bp);
>  }
>  
>  static void
> -xfs_agfl_read_verify(
> +xfs_agfl_write_verify(
>       struct xfs_buf  *bp)
>  {
>       xfs_agfl_verify(bp);
> -     bp->b_pre_io = xfs_agfl_write_verify;
> -     bp->b_iodone = NULL;
> -     xfs_buf_ioend(bp, 0);
>  }

Any good reason to keep all these no-op wrappers?

<Prev in Thread] Current Thread [Next in Thread>