[Top] [All Lists]

Re: [PATCH] xfs: Update inode alloc comments

To: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: Update inode alloc comments
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 23 Oct 2012 08:23:55 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1350742099-8397-1-git-send-email-cmaiolino@xxxxxxxxxx>
References: <1350742099-8397-1-git-send-email-cmaiolino@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Oct 20, 2012 at 11:08:19AM -0300, Carlos Maiolino wrote:
> I found some out of date comments while studying the inode allocation code, 
> so I
> believe it's worth to have these comments updated.
> It basically rewrites the comment regarding to "call_again" variable, which is
> not used anymore, but instead, callers of xfs_ialloc() decides if it needs to 
> be
> called again relying only if ialloc_context is NULL or not.
> Also did some small changes in another comment that I thought to be pertinent
> to the current behaviour of these functions and some alignment on both 
> comments.
> Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>