xfs
[Top] [All Lists]

Re: [PATCH v5 03/10] xfs: create helper to check whether to free eofbloc

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v5 03/10] xfs: create helper to check whether to free eofblocks on inode
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 23 Oct 2012 11:58:28 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1349446636-8611-4-git-send-email-bfoster@xxxxxxxxxx>
References: <1349446636-8611-1-git-send-email-bfoster@xxxxxxxxxx> <1349446636-8611-4-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Oct 05, 2012 at 10:17:09AM -0400, Brian Foster wrote:
> This check is used in multiple places to determine whether we
> should check for (and potentially free) post EOF blocks on an
> inode. Add a helper to consolidate the check.
> 
> Note that when we remove an inode from the cache (xfs_inactive()),
> we are required to trim post-EOF blocks even if the inode is marked
> preallocated or append-only to maintain correct space accounting.
> The 'force' parameter to xfs_can_free_eofblocks() specifies whether
> we should ignore the prealloc/append-only status of the inode.
> 
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>

Looks good. I'm glad this little mess is going away :)

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>