xfs
[Top] [All Lists]

Re: xfstests 250 fail on newer kernels

To: xfs@xxxxxxxxxxx
Subject: Re: xfstests 250 fail on newer kernels
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 22 Oct 2012 09:31:58 +1100
In-reply-to: <20121020112405.GA652@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20121019173730.GA23018@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20121019215343.GX2739@dastard> <20121020112405.GA652@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Oct 20, 2012 at 08:24:05AM -0300, Carlos Maiolino wrote:
> On Sat, Oct 20, 2012 at 08:53:43AM +1100, Dave Chinner wrote:
> > On Fri, Oct 19, 2012 at 02:37:30PM -0300, Carlos Maiolino wrote:
> > > Hi,
> > > 
> > > reviewing a patch to xfstests250, I ran it against newer kernels (3.6.0+ 
> > > and
> > > 3.7.0-rc1) and noticed it is failing. i.e. btree is getting corrupted. 
> > 
> > It's been failing on mainline kernels for a long time. In fact, i
> > think it's been failing since it was created. But it's not failing
> > due to btree corruption - it's failing because mkfs is not leaving
> > enough space in the AG that contains the log for sanity checks to
> > pass. i.e. that there are always a minimum of 4 blocks of freespace
> > in an AG.
> > 
> > This is not actually a problem - the log takes the entire AG, so
> > allocation will never occur in it, so having less than 4 blocks of
> > free space in the AG is just noise in this case. It's never bubbled
> > to the top of my list to fix...
> > 
> > > I'm going to take a look at it, but let me know if anybody has already
> > > found/fixed it.
> > 
> > If it is failing the check_scratch_fs stage, then it is most likely
> > the above issue. The corrupted btree problem that the test was
> > writen for caused the system to ASSERT fail or crash - i.e. it
> > didn't even run to the point of checking the fs....
> > 
> Yep, that was my point, it's failing on check_scratch_fs stage. The btree
> problem has been fixed since it is not triggering the ASSERT. Didn't know it 
> is
> failing since its creation :)
> 
> I can add it to my todo list if you want some stuff out of yours

You can - the simplest thing to do might be just to fix the log size
for the mkfs command to 15MB (i.e. smaller than the AG size) so that
mkfs doesn't use all the space in the AG...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>