xfs
[Top] [All Lists]

Re: [PATCH v2] xfstests: get return value in seek_sanity_test

To: "wenqing.lz" <gnehzuil.liu@xxxxxxxxx>
Subject: Re: [PATCH v2] xfstests: get return value in seek_sanity_test
From: Jie Liu <jeff.liu@xxxxxxxxxx>
Date: Sun, 21 Oct 2012 21:13:01 +0800
Cc: xfs@xxxxxxxxxxx, Zheng Liu <wenqing.lz@xxxxxxxxxx>
In-reply-to: <1350825309-30733-1-git-send-email-wenqing.lz@xxxxxxxxxx>
References: <1350825309-30733-1-git-send-email-wenqing.lz@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0
On 10/21/12 21:15, wenqing.lz wrote:
> From: Zheng Liu <wenqing.lz@xxxxxxxxxx>
>
> In seek_sanity_test getting return value is missing.  Thus we couldn't get the
> result unless someone read the log file (e.g. # 285).
>
> CC: Jeff Liu <jeff.liu@xxxxxxxxxx>
> Signed-off-by: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> ---
> v2 <- v1:
>       * put return value check below the run_test()
>
> Hi Jeff,
>
> Could you please review this patch again?  Thanks.
>
> Regards,
> Zheng
>
>  src/seek_sanity_test.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
> index 34f5508..3897f02 100644
> --- a/src/seek_sanity_test.c
> +++ b/src/seek_sanity_test.c
> @@ -674,9 +674,9 @@ int main(int argc, char **argv)
>               goto out;
>  
>       for (i = 0; i < numtests; ++i) {
> +             ret = run_test(&seek_tests[i]);
>               if (ret)
> -                     goto out;
> -             run_test(&seek_tests[i]);
> +                     break;
>       }
>  
>  out:
Looks good to me, thank you!

-Jeff

<Prev in Thread] Current Thread [Next in Thread>