xfs
[Top] [All Lists]

Re: [PATCH] xfstests: get return value in seek_sanity_test

To: "wenqing.lz" <gnehzuil.liu@xxxxxxxxx>
Subject: Re: [PATCH] xfstests: get return value in seek_sanity_test
From: Jie Liu <jeff.liu@xxxxxxxxxx>
Date: Sun, 21 Oct 2012 20:08:24 +0800
Cc: xfs@xxxxxxxxxxx, Zheng Liu <wenqing.lz@xxxxxxxxxx>
In-reply-to: <1350819548-29634-1-git-send-email-wenqing.lz@xxxxxxxxxx>
References: <1350819548-29634-1-git-send-email-wenqing.lz@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0
Hi Zheng,

On 10/21/12 19:39, wenqing.lz wrote:
> From: Zheng Liu <wenqing.lz@xxxxxxxxxx>
>
> In seek_sanity_test getting return value is missing.  Thus we couldn't get the
> result unless someone read the log file (e.g. # 285).
>
> Signed-off-by: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> ---
>  src/seek_sanity_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
> index 34f5508..e3ed64a 100644
> --- a/src/seek_sanity_test.c
> +++ b/src/seek_sanity_test.c
> @@ -676,7 +676,7 @@ int main(int argc, char **argv)
>       for (i = 0; i < numtests; ++i) {
>               if (ret)
>                       goto out;
> -             run_test(&seek_tests[i]);
> +             ret = run_test(&seek_tests[i]);
Thanks for the patch.
Looks there is another issue regarding the run_test loop, i.e, it should be:

    ret = run_test(&seek_tests[i]);
    if (ret)
        break;

Could you please fix it too?

Thanks,
-Jeff
>       }
>  
>  out:

<Prev in Thread] Current Thread [Next in Thread>