[Top] [All Lists]

Re: [PATCH v5 00/10] speculative preallocation inode tracking

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v5 00/10] speculative preallocation inode tracking
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 19 Oct 2012 16:02:55 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1349446636-8611-1-git-send-email-bfoster@xxxxxxxxxx>
References: <1349446636-8611-1-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 10/05/12 09:17, Brian Foster wrote:
Hi all,

This is v3 of the speculative preallocation inode tracking patchset. This
functionality tracks inodes with post-EOF speculative preallocation for the
purpose of background and on-demand trimming.

Background scanning occurs on a longish interval (5 minutes by default) and in
a best-effort mode (i.e., inodes are skipped due to lock contention or dirty
cache). The intent is to clear up post-EOF blocks on inodes that might have
allocations hanging around due to open-write-close sequences (NFS).

On demand scanning is provided via a new ioctl and supports various parameters
such as scan mode, filtering by quota id and minimum file size. A pending use
case for on demand scanning is for accurate quota accounting via the gluster
scale out filesystem (i.e., to free up preallocated space when near a usage


The series looks great.

I am just curious, what is the reason for the padding in the xfs_eofblocks structure?

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>