xfs
[Top] [All Lists]

Re: [PATCH] mkfs: update manpage to match current inode allocation behav

To: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Subject: Re: [PATCH] mkfs: update manpage to match current inode allocation behaviour
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 18 Oct 2012 17:38:45 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1350574957-1044-1-git-send-email-cmaiolino@xxxxxxxxxx>
References: <1350574957-1044-1-git-send-email-cmaiolino@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:16.0) Gecko/20121010 Thunderbird/16.0.1
On 10/18/12 10:42 AM, Carlos Maiolino wrote:
> Once inode64 is the default allocator, mkfs man page needs to be updated to
> match the current behaviour.
> 
> Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
> ---
>  man/man8/mkfs.xfs.8 | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
> index fa52152..c33cfb2 100644
> --- a/man/man8/mkfs.xfs.8
> +++ b/man/man8/mkfs.xfs.8
> @@ -309,16 +309,17 @@ can be allocated to inodes. The default
>  is 25% for filesystems under 1TB, 5% for filesystems under 50TB and 1%
>  for filesystems over 50TB.
>  .IP
> -In the default inode allocation mode, inode blocks are chosen such
> +In the inode32 inode allocation mode, inode blocks are chosen such
>  that inode numbers will not exceed 32 bits, which restricts the inode
>  blocks to the lower portion of the filesystem. The data block
>  allocator will avoid these low blocks to accommodate the specified
>  maxpct, so a high value may result in a filesystem with nothing but
>  inodes in a significant portion of the lower blocks of the filesystem.
> -(This restriction is not present when the filesystem is mounted with
> +(This restriction is not present in the default inode allocation mode,
> +i.e. when the filesystem is mounted with
>  the
>  .I "inode64"
> -option on 64-bit platforms).
> +option).

This is a little confusing - the "default" mode when "mounted with the -o 
inode64 option?"

If you mount with -o anything that's not quite default - or at best restating 
defaults.

How about:

(This restriction is not present in the default inode allocation mode,
i.e. when the filesystem is mounted without the
 .I "inode32"
option).

-Eric

>  .IP
>  Setting the value to 0 means that essentially all of the filesystem
>  can become inode blocks, subject to inode32 restrictions.
> 

<Prev in Thread] Current Thread [Next in Thread>