xfs
[Top] [All Lists]

Re: xfstests: SEEK_HOLE/SEEK_DATA advanced tests

To: Jie Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: xfstests: SEEK_HOLE/SEEK_DATA advanced tests
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 17 Oct 2012 18:24:24 +1100
Cc: Mark Tinguely <tinguely@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <507E284D.40800@xxxxxxxxxx>
References: <20121016204240.142425319@xxxxxxx> <20121016204244.997819918@xxxxxxx> <20121017023439.GB26797@dastard> <507E284D.40800@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 17, 2012 at 11:38:53AM +0800, Jie Liu wrote:
> On 10/17/12 10:34, Dave Chinner wrote:
> > On Tue, Oct 16, 2012 at 03:42:41PM -0500, Mark Tinguely wrote:
> >> This is the test of the advanced SEEK_HOLE and SEEK_DATA features
> >> of the lseek() function call.
> >>
> >> Jie Liu <jeff.liu@xxxxxxxxxx> wrote the C code, I converted it to
> >> a test with his permission.
> > Jie, can you sign-off on this patch as well as it has Oracle
> > copyright statements in it?
> Hi Dave,
> 
> I can sign-off this patch, but it's better to keep the copyright
> statements with SGI for this test script since
> it wrote by Mark, and Mark is already made the C test file as Oracle.

The .c file has this:

+ * Copyright (C) 2011-2012 Oracle. All rights reserved.

Which is why the patch needs your signoff.

But if the test is redone without the .c file (i.e. SEEK_HOLE/DATA
added to xfs_io) then it won't be necessary (unless you do that
work :).

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>