[Top] [All Lists]

Re: [PATCH 00/14 V5]: xfs: remove the xfssyncd mess

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 00/14 V5]: xfs: remove the xfssyncd mess
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 16 Oct 2012 14:19:44 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1349693772-8064-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1349693772-8064-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey Dave,

On Mon, Oct 08, 2012 at 09:55:58PM +1100, Dave Chinner wrote:
> Hopefully the final version.

I'm giving this the smoke test on v3.7-rc1 before pulling it in.  Hopefully we
can do that tonight or tomorrow.

"xfs: xfs_sync_data is redundant" and "xfs: sync work is now only periodic log
work" had trivial conflicts due to 

commit 43829731dd372d04d6706c51052b9dabab9ca356
Author: Tejun Heo <tj@xxxxxxxxxx>
Date:   Mon Aug 20 14:51:24 2012 -0700

    workqueue: deprecate flush[_delayed]_work_sync()

    flush[_delayed]_work_sync() are now spurious.  Mark them deprecated
    and convert all users to flush[_delayed]_work().

    If you're cc'd and wondering what's going on: Now all workqueues are
    non-reentrant and the regular flushes guarantee that the work item is
    not pending or running on any CPU on return, so there's no reason to
    use the sync flushes at all and they're going away.

    This patch doesn't make any functional difference.


> Version 5:
> - move initial queuing of log work so it isn't started on log mount
>   error
> - move xfs_flush_inodes() to xfs_super.c
> - pass xfs_mount to xfs_flush_inodes()
> - rewrite commit message for xfs_flush_inodes() changes
> - added last_sync_lsn fix to series as the problem it fixes is
>   reliably exposed by the changes in this series
> Version 4:
> - updated 'xfs: xfs_sync_data is redundant' with cleanups to the
>   xfs_flush_inodes interface as per Christoph's request,
> - updated 'xfs: xfs_sync_data is redundant', folding in changes from
>   http://oss.sgi.com/archives/xfs/2012-10/msg00036.html
> - fixed a minor typo in xfs: 'syncd workqueue is no more', renaming the
>   log worker from 'xfs-reclaim' to 'xfs-log'.
> Version 3:
> - per-mount log and reclaim workqueues instead of a generic mount
>   workqueue.
> - reordering of some of the patches as Christoph requested.
> - fixed the writeback_inodes_sb_if_idle deadlock by moving it all
>   the way back up the write stack to xfs_file_aio_buffered_write
>   where we were just flushing the current file to avoid deadlocking
>   on it anyway.
> - reintroduced xfs_flush_inodes() as a wrapper for
>   writeback_inodes_sb_if_idle().
> - rebased on a current TOT.
> Version 2:
> - fix writeback_inodes_sb_if_idle call in xfs_create()
> - refreshed patch 13 before sending.
> Initial version:
> - http://oss.sgi.com/archives/xfs/2012-06/msg00064.html
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>