xfs
[Top] [All Lists]

Re: [PATCH] xfs_quota: XFS_XFLAG_PROJINHERIT is only for dirs

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs_quota: XFS_XFLAG_PROJINHERIT is only for dirs
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sat, 13 Oct 2012 16:22:24 -0500
Cc: nscott@xxxxxxxxxx, Dave Chinner <dchinner@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20121013155205.GA11037@xxxxxxxxxxxxx>
References: <5078432B.6050501@xxxxxxxxxx> <20121013155205.GA11037@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:16.0) Gecko/20121010 Thunderbird/16.0.1
On 10/13/12 10:52 AM, Christoph Hellwig wrote:
> On Fri, Oct 12, 2012 at 11:19:55AM -0500, Eric Sandeen wrote:
>> xfs_quota has long set XFS_XFLAG_PROJINHERIT on all files,
>> and tested for presence on all files.  However, Dave's semi-recent
>> xfs_repair update is now flagging this as an error:
> 
> I think we should rever that part of the repair patch.  While there
> really is not point to have XFS_XFLAG_PROJINHERIT set on non-directory
> files we have been setting it for year, so repair should cope with that.
> 
> I'd also like to have a test checking that repair does not complain
> about XFS_XFLAG_PROJINHERIT being set on a non-directory to verify this.

Ok, seems reasonable.  Presumably I'd need to remove my change
to check_project() as well.  I should probably send V2, then.

Kind of amazing that this was missed for so long ;)

Thanks,
-Eric

> For the future I'm fine with not setting it on non-directories anymore,
> so:
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 
> for this patch after a slight update to the commit message.
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>