xfs
[Top] [All Lists]

Re: [PATCH 08/19] xfs: verify inode buffers as they are read from disk

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 08/19] xfs: verify inode buffers as they are read from disk
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 12 Oct 2012 08:55:48 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20121011214555.GH6346@xxxxxxxxxxxxx>
References: <1349754670-32009-1-git-send-email-david@xxxxxxxxxxxxx> <1349754670-32009-9-git-send-email-david@xxxxxxxxxxxxx> <20121011214555.GH6346@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 11, 2012 at 05:45:56PM -0400, Christoph Hellwig wrote:
> > +           if (unlikely(XFS_TEST_ERROR(!di_ok, mp,
> > +                                           XFS_ERRTAG_ITOBP_INOTOBP,
> > +                                           XFS_RANDOM_ITOBP_INOTOBP))) {
> > +                   xfs_buf_ioerror(bp, EFSCORRUPTED);
> > +                   XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_HIGH,
> > +                                        mp, dip);
> > +#ifdef DEBUG
> > +                   xfs_emerg(mp,
> > +                           "bad inode magic/vsn daddr %lld #%d (magic=%x)",
> > +                           (unsigned long long)bp->b_bn, i,
> > +                           be16_to_cpu(dip->di_magic));
> > +                   ASSERT(0);
> > +#endif
> 
> Is there any point in having this additional output in addition to the
> high error level corruption report above?

IMO, yes. It has the block number in it and it stops the operation
immediately, so you can look at it with xfs_db and see the current
state on disk without it being further modified. Otherwise all we
know is that an inode failed validation without any specific
information as to where it is.

It's quite a way down my list of things to do before I get to the
"put lots more information in failure messages" line item....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>