xfs
[Top] [All Lists]

Re: [PATCH 08/19] xfs: verify inode buffers as they are read from disk

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 08/19] xfs: verify inode buffers as they are read from disk
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 11 Oct 2012 17:45:56 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1349754670-32009-9-git-send-email-david@xxxxxxxxxxxxx>
References: <1349754670-32009-1-git-send-email-david@xxxxxxxxxxxxx> <1349754670-32009-9-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> +             if (unlikely(XFS_TEST_ERROR(!di_ok, mp,
> +                                             XFS_ERRTAG_ITOBP_INOTOBP,
> +                                             XFS_RANDOM_ITOBP_INOTOBP))) {
> +                     xfs_buf_ioerror(bp, EFSCORRUPTED);
> +                     XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_HIGH,
> +                                          mp, dip);
> +#ifdef DEBUG
> +                     xfs_emerg(mp,
> +                             "bad inode magic/vsn daddr %lld #%d (magic=%x)",
> +                             (unsigned long long)bp->b_bn, i,
> +                             be16_to_cpu(dip->di_magic));
> +                     ASSERT(0);
> +#endif

Is there any point in having this additional output in addition to the
high error level corruption report above?

<Prev in Thread] Current Thread [Next in Thread>