Re: [PATCH 07/19] xfs: verify AGFL blocks as they are read from disk

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 07/19] xfs: verify AGFL blocks as they are read from disk
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 11 Oct 2012 17:44:21 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1349754670-32009-8-git-send-email-david@xxxxxxxxxxxxx>
References:	<1349754670-32009-1-git-send-email-david@xxxxxxxxxxxxx> <1349754670-32009-8-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Oct 09, 2012 at 02:50:58PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Add an AGFL block verify callback function and pass it into the
> buffer read functions. Add a debug only check for valid block
> numbers in the AGFL.

The check isn't executed only for debug builds, but rather all
the time.  I'm not sure that this actually is a good idea.

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 04/19] xfs: verify superblocks as they are read from disk, (continued) Re: [PATCH 04/19] xfs: verify superblocks as they are read from disk, Dave Chinner [PATCH 08/19] xfs: verify inode buffers as they are read from disk, Dave Chinner Re: [PATCH 08/19] xfs: verify inode buffers as they are read from disk, Christoph Hellwig Re: [PATCH 08/19] xfs: verify inode buffers as they are read from disk, Dave Chinner [PATCH 14/19] xfs: factor dir2 free block reading, Dave Chinner [PATCH 03/19] xfs: uncached buffer reads need to return an error, Dave Chinner Re: [PATCH 03/19] xfs: uncached buffer reads need to return an error, Christoph Hellwig Re: [PATCH 03/19] xfs: uncached buffer reads need to return an error, Dave Chinner Re: [PATCH 03/19] xfs: uncached buffer reads need to return an error, Dave Chinner [PATCH 07/19] xfs: verify AGFL blocks as they are read from disk, Dave Chinner Re: [PATCH 07/19] xfs: verify AGFL blocks as they are read from disk, Christoph Hellwig <= Re: [PATCH 07/19] xfs: verify AGFL blocks as they are read from disk, Dave Chinner [PATCH 10/19] xfs: verify dquot blocks as they are read from disk, Dave Chinner Re: [PATCH 10/19] xfs: verify dquot blocks as they are read from disk, Christoph Hellwig Re: [PATCH 10/19] xfs: verify dquot blocks as they are read from disk, Dave Chinner [PATCH 09/19] xfs: verify btree blocks as they are read from disk, Dave Chinner [PATCH 12/19] xfs: factor dir2 block read operations, Dave Chinner [PATCH 16/19] xfs: factor dir2 leaf read, Dave Chinner [PATCH 17/19] xfs: factor and verify attr leaf reads, Dave Chinner [PATCH 13/19] xfs: verify dir2 block format buffers, Dave Chinner [PATCH 11/19] xfs: add verifier callback to directorry read code, Dave Chinner

Previous by Date:	Re: [PATCH 06/19] xfs: verify AGI blocks as they are read from disk, Christoph Hellwig
Next by Date:	Re: [PATCH 08/19] xfs: verify inode buffers as they are read from disk, Christoph Hellwig
Previous by Thread:	[PATCH 07/19] xfs: verify AGFL blocks as they are read from disk, Dave Chinner
Next by Thread:	Re: [PATCH 07/19] xfs: verify AGFL blocks as they are read from disk, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]