xfs
[Top] [All Lists]

Re: [PATCH 07/19] xfs: verify AGFL blocks as they are read from disk

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 07/19] xfs: verify AGFL blocks as they are read from disk
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 11 Oct 2012 17:44:21 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1349754670-32009-8-git-send-email-david@xxxxxxxxxxxxx>
References: <1349754670-32009-1-git-send-email-david@xxxxxxxxxxxxx> <1349754670-32009-8-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Oct 09, 2012 at 02:50:58PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Add an AGFL block verify callback function and pass it into the
> buffer read functions. Add a debug only check for valid block
> numbers in the AGFL.

The check isn't executed only for debug builds, but rather all
the time.  I'm not sure that this actually is a good idea.

<Prev in Thread] Current Thread [Next in Thread>