Re: [PATCH v2] xfs: avoid underflow in xfs_ioc

xfs

Re: [PATCH v2] xfs: avoid underflow in xfs_ioc_trim()

To:	Lukas Czerner <lczerner@xxxxxxxxxx>
Subject:	Re: [PATCH v2] xfs: avoid underflow in xfs_ioc_trim()
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Fri, 12 Oct 2012 08:35:33 +1100
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1349944432-13776-1-git-send-email-lczerner@xxxxxxxxxx>
References:	<1349944432-13776-1-git-send-email-lczerner@xxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Thu, Oct 11, 2012 at 10:33:52AM +0200, Lukas Czerner wrote:
> Currently if len argument in xfs_ioc_trim() is smaller than one FSB
> the 'end' variable underflow. Avoid that by returning EINVAL when
> range is smaller than FSB.
> 
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>

Just a thought - wouldn't this be better done at the VFS so it is
consistent across all filesystems? i.e. using inode->i_blkbits?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH v2] xfs: avoid underflow in xfs_ioc_trim(), Lukas Czerner Re: [PATCH v2] xfs: avoid underflow in xfs_ioc_trim(), Dave Chinner <= Re: [PATCH v2] xfs: avoid underflow in xfs_ioc_trim(), Lukáš Czerner Re: [PATCH v2] xfs: avoid underflow in xfs_ioc_trim(), Dave Chinner

Previous by Date:	Re: [PATCH 01/19] xfs: growfs: don't read garbage for new secondary superblocks, Christoph Hellwig
Next by Date:	Re: [PATCH 02/19] xfs: make buffer read verication an IO completion function, Christoph Hellwig
Previous by Thread:	[PATCH v2] xfs: avoid underflow in xfs_ioc_trim(), Lukas Czerner
Next by Thread:	Re: [PATCH v2] xfs: avoid underflow in xfs_ioc_trim(), Lukáš Czerner
Indexes:	[Date] [Thread] [Top] [All Lists]