Re: [PATCH 01/19] xfs: growfs: don't read garbage for new secondary supe

xfs

Re: [PATCH 01/19] xfs: growfs: don't read garbage for new secondary supe

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 01/19] xfs: growfs: don't read garbage for new secondary superblocks
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 11 Oct 2012 17:34:23 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1349754670-32009-2-git-send-email-david@xxxxxxxxxxxxx>
References:	<1349754670-32009-1-git-send-email-david@xxxxxxxxxxxxx> <1349754670-32009-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Oct 09, 2012 at 02:50:52PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When updating new secondary superblocks in a growfs operation, the
> sueprblock buffer is read from the newly grown region of the
> underlying device. This is not guaranteed to be zero, so violates
> the underlying assumption that the unused parts of superblocks are
> zero filled. Get a new buffer for these secondary superblocks to
> ensure that the unused regions are zero filled correctly.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/19] xfs: buffer read verifier infrastructure, Dave Chinner [PATCH 01/19] xfs: growfs: don't read garbage for new secondary superblocks, Dave Chinner Re: [PATCH 01/19] xfs: growfs: don't read garbage for new secondary superblocks, Christoph Hellwig <= [PATCH 05/19] xfs: verify AGF blocks as they are read from disk, Dave Chinner Re: [PATCH 05/19] xfs: verify AGF blocks as they are read from disk, Christoph Hellwig [PATCH 06/19] xfs: verify AGI blocks as they are read from disk, Dave Chinner Re: [PATCH 06/19] xfs: verify AGI blocks as they are read from disk, Christoph Hellwig [PATCH 02/19] xfs: make buffer read verication an IO completion function, Dave Chinner Re: [PATCH 02/19] xfs: make buffer read verication an IO completion function, Christoph Hellwig [PATCH 04/19] xfs: verify superblocks as they are read from disk, Dave Chinner Re: [PATCH 04/19] xfs: verify superblocks as they are read from disk, Christoph Hellwig Re: [PATCH 04/19] xfs: verify superblocks as they are read from disk, Dave Chinner [PATCH 08/19] xfs: verify inode buffers as they are read from disk, Dave Chinner

Previous by Date:	Re: possible memory allocation deadlock in xfs_buf_allocate_memory, Dave Chinner
Next by Date:	Re: [PATCH v2] xfs: avoid underflow in xfs_ioc_trim(), Dave Chinner
Previous by Thread:	[PATCH 01/19] xfs: growfs: don't read garbage for new secondary superblocks, Dave Chinner
Next by Thread:	[PATCH 05/19] xfs: verify AGF blocks as they are read from disk, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]