xfs
[Top] [All Lists]

Re: [PATCH 2/2 V2] xfs_io: configure tests for preadv/pwritev & sync_fil

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 2/2 V2] xfs_io: configure tests for preadv/pwritev & sync_file_range
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 11 Oct 2012 10:25:53 +1100
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <5074EE1B.3090600@xxxxxxxxxxx>
References: <50749EE2.6070408@xxxxxxxxxx> <5074A05A.6000709@xxxxxxxxxxx> <5074EE1B.3090600@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Oct 09, 2012 at 10:40:11PM -0500, Eric Sandeen wrote:
> On older systems we may not have preadv/pwritev and/or
> sync_file_range.
> 
> Add the configure magic, and stub out the code
> where needed.
> 
> (sync_file_range just needed a better test; preadv/pwritev
> took a little more rearranging)
> 
> And fix a couple typos ("numberic") while we're at it.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> V2: add -DHAVE_PWRITEV and use that test in io/pwrite.c
> rather than HAVE_PREADV
.....

> +# Also implies PWRITEV
> +ifeq ($(HAVE_PREADV),yes)
> +LCFLAGS += -DHAVE_PREADV -DHAVE_PWRITEV
> +endif

Nice solution ;)

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>