[Top] [All Lists]

Re: [PATCH 06/14] xfs: xfs_sync_data is redundant.

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 06/14] xfs: xfs_sync_data is redundant.
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Tue, 09 Oct 2012 18:23:23 -0400
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20121009214144.GU13214@xxxxxxx>
References: <1349693772-8064-1-git-send-email-david@xxxxxxxxxxxxx> <1349693772-8064-7-git-send-email-david@xxxxxxxxxxxxx> <20121009210124.GT13214@xxxxxxx> <20121009212851.GP23644@dastard> <20121009214144.GU13214@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0
On 10/09/2012 05:41 PM, Ben Myers wrote:
> Hey,
> On Wed, Oct 10, 2012 at 08:28:51AM +1100, Dave Chinner wrote:
>> On Tue, Oct 09, 2012 at 04:01:24PM -0500, Ben Myers wrote:
>>> Hi Brain,
>> [Pinky: "Gee, Brain, what do you want to do tonight?"
>>  Brain: "The same thing we do every night, Pinky - try to take over
>>         the world!"]
> Wish I could say I called him 'brain' on purpose.  Will you be playing the 
> part
> of Pinky in today's show?  ;)

Heh, it happens more than you would think. ;)

>>> Given that you found the regression in the output of xfstest 273, could you
>>> do us a favor and review the fix and provide your Reviewed-by, and/or
>>> Tested-by?
>> Brian did test it, just as separate patches:
>> http://oss.sgi.com/archives/xfs/2012-10/msg00037.html
> Brian, would you mind extending your Tested-by?

Sure, I tested Dave's change to xfs_flush_inodes() against 273 and ran
another full test against the entire v3 set on that hardware, without
any further noticeable issues.

Tested-by: Brian Foster <bfoster@xxxxxxxxxx>


> Regards,
>       Ben

<Prev in Thread] Current Thread [Next in Thread>