xfs
[Top] [All Lists]

Re: [PATCH] 260: Add another corner case where length is zero

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] 260: Add another corner case where length is zero
From: Lukáš Czerner <lczerner@xxxxxxxxxx>
Date: Tue, 9 Oct 2012 23:23:13 +0200 (CEST)
Cc: Lukas Czerner <lczerner@xxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20121009194019.GJ23644@dastard>
References: <1349785012-28588-1-git-send-email-lczerner@xxxxxxxxxx> <20121009194019.GJ23644@dastard>
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Wed, 10 Oct 2012, Dave Chinner wrote:

> Date: Wed, 10 Oct 2012 06:40:19 +1100
> From: Dave Chinner <david@xxxxxxxxxxxxx>
> To: Lukas Czerner <lczerner@xxxxxxxxxx>
> Cc: xfs@xxxxxxxxxxx
> Subject: Re: [PATCH] 260: Add another corner case where length is zero
> 
> On Tue, Oct 09, 2012 at 02:16:52PM +0200, Lukas Czerner wrote:
> > This commit adds another corner case to test FITRIM argument handling.
> > In this case we set length to zero and we expect the number of discarded
> > bytes to be obviously zero, however we've had bug in both ext4 and xfs
> > where the internal variable would underflow. This test case will be able
> > to catch that in future.
> > 
> > Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
> 
> I'd create another test for this, rather than making 260 suddenly
> fail for everyone....

Hmm, I am not sure what is the point. I've created 260 exactly for
this reason of testing FITRIM argument handling and it already
contains number of tests like this one. I am not strongly against
having this in separate test, however it seems rather unnecessary to
me.

Thanks!
-Lukas

> 
> Cheers,
> 
> Dave.
> 

<Prev in Thread] Current Thread [Next in Thread>