xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfsprogs: report projid32 status in growfs output

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfsprogs: report projid32 status in growfs output
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 10 Oct 2012 06:47:52 +1100
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <5074792A.2080509@xxxxxxxxxxx>
References: <50747753.6040105@xxxxxxxxxx> <5074792A.2080509@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Oct 09, 2012 at 02:21:14PM -0500, Eric Sandeen wrote:
> With the projid32 flag now in the FSGEOM ioctl results we
> can report projid32 status in xfs_growfs / xfs_info output,
> to match the mkfs.xfs output.
> 
> However, since the flag was only recently added to the kernel,
> we may get some incorrect reports of "projid32bit=0"
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> ... and I don't know how big a problem those incorrect reports
> might be ...

I doubt it will be a problem - the 32bit projid is pretty
self-contained, and we can still get the info from xfs_db if we
really need to confirm that it is set.

Code looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>