xfs
[Top] [All Lists]

Re: [PATCH] xfs: report projid32bit feature in geometry call

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: report projid32bit feature in geometry call
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 10 Oct 2012 06:45:22 +1100
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <507476F1.3080503@xxxxxxxxxx>
References: <507476F1.3080503@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Oct 09, 2012 at 02:11:45PM -0500, Eric Sandeen wrote:
> When xfs gained the projid32bit feature, it was never added to
> the FSGEOMETRY ioctl feature flags, so it's not queryable without
> this patch.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> note1: is there a reason we had gaps in the flags?

No idea. I don't think it matters, though.

> note2: I don't *think* this requires a new version for the ioctl

No, it doesn't - the structure format is unchanged.

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>