xfs
[Top] [All Lists]

Re: [PATCH] xfstests: 251, 260: Use loopdev as fallback if $SCRATCH_DEV

To: Tomas Racek <tracek@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: 251, 260: Use loopdev as fallback if $SCRATCH_DEV doesn't support FITRIM
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 10 Oct 2012 06:42:40 +1100
Cc: xfs@xxxxxxxxxxx, lczerner@xxxxxxxxxx
In-reply-to: <1349796000-27776-1-git-send-email-tracek@xxxxxxxxxx>
References: <1349796000-27776-1-git-send-email-tracek@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Oct 09, 2012 at 05:20:00PM +0200, Tomas Racek wrote:
> This patch adds an option to test FITRIM even if it's not supported on 
> $SCRATCH_DEV. 
> 
> Also introduces _create_loop_device and _destroy_loop_device functions to
> unify loopback handling.

That should be a separate patch.

> (depends on patch "Use upstream version of fstrim...")
> 
> Signed-off-by: Tomas Racek <tracek@xxxxxxxxxx>

Write a new test that uses the loop device unconditionally and move
common functions into the relevant (or new) common.<foo> file.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>