xfs
[Top] [All Lists]

Re: [PATCH] 260: Add another corner case where length is zero

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH] 260: Add another corner case where length is zero
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 10 Oct 2012 06:40:19 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1349785012-28588-1-git-send-email-lczerner@xxxxxxxxxx>
References: <1349785012-28588-1-git-send-email-lczerner@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Oct 09, 2012 at 02:16:52PM +0200, Lukas Czerner wrote:
> This commit adds another corner case to test FITRIM argument handling.
> In this case we set length to zero and we expect the number of discarded
> bytes to be obviously zero, however we've had bug in both ext4 and xfs
> where the internal variable would underflow. This test case will be able
> to catch that in future.
> 
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>

I'd create another test for this, rather than making 260 suddenly
fail for everyone....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>