xfs
[Top] [All Lists]

Re: [patch v4 04/13] [PATCH 04/13] xfs: sync work is now only periodic l

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch v4 04/13] [PATCH 04/13] xfs: sync work is now only periodic log work
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 05 Oct 2012 13:31:40 -0500
Cc: Ben Myers <bpm@xxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20121005181645.GB1056@xxxxxxxxxxxxx>
References: <20121005171853.985930109@xxxxxxx> <20121005171945.888412779@xxxxxxx> <20121005181645.GB1056@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 10/05/12 13:16, Christoph Hellwig wrote:
On Fri, Oct 05, 2012 at 12:18:57PM -0500, Ben Myers wrote:
                ASSERT(mp->m_flags&  XFS_MOUNT_RDONLY);
        }

+       xfs_log_work_queue(mp);
+
        return error;

I still think queueing the work item here if we return a failure is
the wrong thing to do.

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs

You are correct. I did not see that it was not moved when mentioned in the first series.

--Mark.

<Prev in Thread] Current Thread [Next in Thread>