xfs
[Top] [All Lists]

Re: [patch v4 04/13] [PATCH 04/13] xfs: sync work is now only periodic l

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [patch v4 04/13] [PATCH 04/13] xfs: sync work is now only periodic log work
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 5 Oct 2012 14:16:45 -0400
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Dave Chinner <dchinner@xxxxxxxxxx>
In-reply-to: <20121005171945.888412779@xxxxxxx>
References: <20121005171853.985930109@xxxxxxx> <20121005171945.888412779@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Oct 05, 2012 at 12:18:57PM -0500, Ben Myers wrote:
>               ASSERT(mp->m_flags & XFS_MOUNT_RDONLY);
>       }
>  
> +     xfs_log_work_queue(mp);
> +
>       return error;

I still think queueing the work item here if we return a failure is
the wrong thing to do.

<Prev in Thread] Current Thread [Next in Thread>