[Top] [All Lists]

Re: Why xfs_<utils> not 'readline' w/line-edit & history enabled? (+atta

To: Linda Walsh <xfs@xxxxxxxxx>
Subject: Re: Why xfs_<utils> not 'readline' w/line-edit & history enabled? (+attachment)
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 3 Oct 2012 09:50:42 +1000
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <506B7A1C.3000001@xxxxxxxxx>
References: <506B1A03.7030600@xxxxxxxxx> <20121002201748.GQ23520@dastard> <506B5DE1.4020000@xxxxxxxxx> <20121002215253.GT23520@dastard> <506B7018.7040000@xxxxxxxxx> <20121002231359.GV23520@dastard> <506B7A1C.3000001@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Oct 02, 2012 at 04:34:52PM -0700, Linda Walsh wrote:
> Dave Chinner wrote:
> >On Tue, Oct 02, 2012 at 03:52:08PM -0700, Linda Walsh wrote:
> >>Dave Chinner wrote:
> >>>Patches welcome.
> >>>
> >>>Cheers,
> >>>
> >>>Dave.
> >>---
> >>Gee, that's a hard one... (build and tested that it was included)...
> >
> >Actually, it's a lot more than just changing the default. If the
> >build system doesn't have libreadline/libedit/libtermcap installed,
> >the build will fail.
> >
> >You need to add detection of the libraries' presence on the build
> >system, and then the "--enable-*" options can go away entirely.
> >See, for example, the way libuuid is detected in
> >m4/package_uuiddev.m4...
> ----
> Hmmm...Oh...I thought configure did that detection.. Now I see that
> was never put it and it was basically a 'manual' on/off switch
> that was available.


> Urk.
> On top of matters, my local distrib had readline installed in a way that
> it wouldn't link had libreadline.so.x.y, libreadline.so.x => 
> libreadline.so.x.y in
> /usr/lib64 but libreadline.so=>libreadline.so.x was in
> /usr/lib64/readline/libreadline.so.
> ???
> Will have to figure out why that is and where it is supposed to be (I just
> moved the soft-link from /usr/lib64/readline/libreadline.so to one dir up -- 
> same
> with libeditline...

Check what your /etc/ld.so.conf looks at - it might just be fine.

> >Also, libedit is only supposed to be used as a fallback option if
> >libreadline is not available.
> ---
> Oh... thought readline did the history part and edit did the edit part...
> Oi vey...

$ gl -n 1 d4b9ebd
commit d4b9ebda67cabf50ba9865880403a89e6b4bc3e7
Author: Nathan Scott <nathans@xxxxxxx>
Date:   Wed Apr 16 23:38:03 2003 +0000

    Add editline support in for cases where readline is unavailable.

> Sigh.  That I actually thought something might be simple... what an idiot!



Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>