xfs
[Top] [All Lists]

Re: Why xfs_<utils> not 'readline' w/line-edit & history enabled? (+atta

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: Why xfs_<utils> not 'readline' w/line-edit & history enabled? (+attachment)
From: Linda Walsh <xfs@xxxxxxxxx>
Date: Tue, 02 Oct 2012 16:34:52 -0700
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20121002231359.GV23520@dastard>
References: <506B1A03.7030600@xxxxxxxxx> <20121002201748.GQ23520@dastard> <506B5DE1.4020000@xxxxxxxxx> <20121002215253.GT23520@dastard> <506B7018.7040000@xxxxxxxxx> <20121002231359.GV23520@dastard>
User-agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.24) Gecko/20100228 Lightning/0.9 Thunderbird/2.0.0.24 Mnenhy/0.7.6.666


Dave Chinner wrote:
On Tue, Oct 02, 2012 at 03:52:08PM -0700, Linda Walsh wrote:
Dave Chinner wrote:
Patches welcome.

Cheers,

Dave.
---
Gee, that's a hard one... (build and tested that it was included)...

Actually, it's a lot more than just changing the default. If the
build system doesn't have libreadline/libedit/libtermcap installed,
the build will fail.

You need to add detection of the libraries' presence on the build
system, and then the "--enable-*" options can go away entirely.
See, for example, the way libuuid is detected in
m4/package_uuiddev.m4...
----
Hmmm...Oh...I thought configure did that detection.. Now I see that
was never put it and it was basically a 'manual' on/off switch
that was available.

Urk.

On top of matters, my local distrib had readline installed in a way that
it wouldn't link had libreadline.so.x.y, libreadline.so.x => libreadline.so.x.y 
in
/usr/lib64 but libreadline.so=>libreadline.so.x was in /usr/lib64/readline/libreadline.so.

???
Will have to figure out why that is and where it is supposed to be (I just
moved the soft-link from /usr/lib64/readline/libreadline.so to one dir up -- 
same
with libeditline...


Also, libedit is only supposed to be used as a fallback option if
libreadline is not available.
---
Oh... thought readline did the history part and edit did the edit part...
Oi vey...

Well.. hrumph...

Will have to look this over when i get some more time.
Have a system disk upgrade to do first...

Sigh.  That I actually thought something might be simple... what an idiot!


<Prev in Thread] Current Thread [Next in Thread>