xfs
[Top] [All Lists]

Re: [PATCH 07/13] xfs: syncd workqueue is no more

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH 07/13] xfs: syncd workqueue is no more
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 1 Oct 2012 12:54:02 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <5065E9A3.3040707@xxxxxxx>
References: <1348807485-20165-1-git-send-email-david@xxxxxxxxxxxxx> <1348807485-20165-8-git-send-email-david@xxxxxxxxxxxxx> <5065E9A3.3040707@xxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Sep 28, 2012 at 01:17:07PM -0500, Mark Tinguely wrote:
> On 09/27/12 23:44, Dave Chinner wrote:
> >From: Dave Chinner<dchinner@xxxxxxxxxx>
> >
> >With the syncd functions moved to the log and/or removed, the syncd
> >workqueue is the only remaining bit left. It is used by the log
> >covering/ail pushing work, as well as by the inode reclaim work.
> >
> >Given how cheap workqueues are these days, give the log and inode
> >reclaim work their own work queues and kill the syncd work queue.
> >
> >Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
> >---
> 
> <deleted info>
> 
> >diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> >index fed1eb2..65cf42c 100644
> >--- a/fs/xfs/xfs_super.c
> >+++ b/fs/xfs/xfs_super.c
> >@@ -776,8 +776,23 @@ xfs_init_mount_workqueues(
> >                     WQ_MEM_RECLAIM, 0, mp->m_fsname);
> >     if (!mp->m_cil_workqueue)
> >             goto out_destroy_unwritten;
> >+
> >+    mp->m_reclaim_workqueue = alloc_workqueue("xfs-reclaim/%s",
> >+                    WQ_NON_REENTRANT, 0, mp->m_fsname);
> >+    if (!mp->m_reclaim_workqueue)
> >+            goto out_destroy_cil;
> >+
> >+    mp->m_log_workqueue = alloc_workqueue("xfs-reclaim/%s",
> >+                    WQ_NON_REENTRANT, 0, mp->m_fsname);

Changed this to "xfs-log/%s" on Dave's behalf.

-Ben

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 07/13] xfs: syncd workqueue is no more, Ben Myers <=