Re: [PATCH 07/13] xfs: syncd workqueue is no more

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 07/13] xfs: syncd workqueue is no more
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Fri, 28 Sep 2012 08:35:06 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1348807485-20165-8-git-send-email-david@xxxxxxxxxxxxx>
References:	<1348807485-20165-1-git-send-email-david@xxxxxxxxxxxxx> <1348807485-20165-8-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Fri, Sep 28, 2012 at 02:44:39PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> With the syncd functions moved to the log and/or removed, the syncd
> workqueue is the only remaining bit left. It is used by the log
> covering/ail pushing work, as well as by the inode reclaim work.
> 
> Given how cheap workqueues are these days, give the log and inode
> reclaim work their own work queues and kill the syncd work queue.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 03/13] xfs: don't run the sync work if the filesystem is read-only, (continued) [PATCH 03/13] xfs: don't run the sync work if the filesystem is read-only, Dave Chinner Re: [PATCH 03/13] xfs: don't run the sync work if the filesystem is read-only, Christoph Hellwig [PATCH 04/13] xfs: sync work is now only periodic log work, Dave Chinner Re: [PATCH 04/13] xfs: sync work is now only periodic log work, Christoph Hellwig [PATCH 05/13] xfs: Bring some sanity to log unmounting, Dave Chinner [PATCH 06/13] xfs: xfs_sync_data is redundant., Dave Chinner Re: [PATCH 06/13] xfs: xfs_sync_data is redundant., Christoph Hellwig Re: [PATCH 06/13] xfs: xfs_sync_data is redundant., Mark Tinguely [PATCH 08/13] xfs: xfs_sync_fsdata is redundant, Dave Chinner [PATCH 07/13] xfs: syncd workqueue is no more, Dave Chinner Re: [PATCH 07/13] xfs: syncd workqueue is no more, Christoph Hellwig <= Re: [PATCH 07/13] xfs: syncd workqueue is no more, Mark Tinguely [PATCH 10/13] xfs: xfs_quiesce_attr() should quiesce the log like unmount, Dave Chinner [PATCH 09/13] xfs: move xfs_quiesce_attr() into xfs_super.c, Dave Chinner [PATCH 12/13] xfs: move inode locking functions to xfs_inode.c, Dave Chinner [PATCH 11/13] xfs: rename xfs_sync.[ch] to xfs_icache.[ch], Dave Chinner [PATCH 13/13] xfs: remove xfs_iget.c, Dave Chinner

Previous by Date:	Re: [PATCH 06/13] xfs: xfs_sync_data is redundant., Christoph Hellwig
Next by Date:	Re: [PATCH] xfs: only update the last_sync_lsn when a transaction completes, Christoph Hellwig
Previous by Thread:	[PATCH 07/13] xfs: syncd workqueue is no more, Dave Chinner
Next by Thread:	Re: [PATCH 07/13] xfs: syncd workqueue is no more, Mark Tinguely
Indexes:	[Date] [Thread] [Top] [All Lists]