[Top] [All Lists]

Re: [PATCH 04/13] xfs: sync work is now only periodic log work

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 04/13] xfs: sync work is now only periodic log work
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 28 Sep 2012 08:31:23 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1348807485-20165-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1348807485-20165-1-git-send-email-david@xxxxxxxxxxxxx> <1348807485-20165-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Sep 28, 2012 at 02:44:36PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> The only thing the periodic sync work does now is flush the AIL and
> idle the log. These are really functions of the log code, so move
> the work to xfs_log.c and rename it appropriately.
> The only wart that this leaves behind is the xfssyncd_centisecs
> sysctl, otherwise the xfssyncd is dead. Clean up any comments that
> related to xfssyncd to reflect it's passing.

You'll get an OK for me as I'd like this series in 3.7, but I'd really
prefer if we could stop waking up xfsaild from here ASAP, and instead
just do a schedule_timeout in xfsaild where we currently sleep forever.

Any chance to get a follow on patch for that?

> +#include "xfs_fsops.h"
>  kmem_zone_t  *xfs_log_ticket_zone;
> @@ -698,6 +699,8 @@ xfs_log_mount_finish(xfs_mount_t *mp)
>               ASSERT(mp->m_flags & XFS_MOUNT_RDONLY);
>       }
> +     xfs_log_work_queue(mp);
> +
>       return error;

I think this should only be called when xlog_recover_finish didn't
return an error.

<Prev in Thread] Current Thread [Next in Thread>