xfs
[Top] [All Lists]

Re: [PATCH v4 4/8] xfs: export xfs_free_eofblocks() and return EAGAIN on

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v4 4/8] xfs: export xfs_free_eofblocks() and return EAGAIN on trylock failure
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 28 Sep 2012 17:00:52 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1348767952-24229-5-git-send-email-bfoster@xxxxxxxxxx>
References: <1348767952-24229-1-git-send-email-bfoster@xxxxxxxxxx> <1348767952-24229-5-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Sep 27, 2012 at 01:45:48PM -0400, Brian Foster wrote:
> Turn xfs_free_eofblocks() into a non-static function, return EAGAIN to
> indicate trylock failure and make sure this error is not propagated in
> xfs_release().

You might want to change the title of the patch - "export" when
talking about functions in kernel code has specific meaning i.e.
EXPORT_SYMBOL() and that's different to making something
non-static...

Otherwise looks ok.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>