xfs
[Top] [All Lists]

Re: [PATCH] xfstests 068: Add mmap load

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests 068: Add mmap load
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 28 Sep 2012 14:36:02 +1000
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <50651A99.1070307@xxxxxxxxxx>
References: <50651A99.1070307@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Sep 27, 2012 at 10:33:45PM -0500, Eric Sandeen wrote:
> Test 068 is the go-to test for freeze deadlock coverage;
> unfortunately it only uses fsstress, which doesn't do any mmap
> IO.
> 
> Using the existing fstest binary gets us a cheap mmap exerciser
> as well.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> I think it's fair to modify this test vs. making a new one -
> it's never passed yet, and will only start passing in kernel 3.6,
> so it shouldn't cause new test regressions to add mmap ops.
> 
> And I can verify that this finds mmap bugs; I had a backport
> which messed up ext4's freeze vs. mmap handling, and this exposes
> it.  :)
> 
> 
> diff --git a/068 b/068
> index 617420c..a0bf425 100755
> --- a/068
> +++ b/068
> @@ -90,6 +90,21 @@ touch $tmp.running
>      rmdir $STRESS_DIR
>  } &
>  
> +# start fstest -m loop in a background block; this gets us mmap coverage
> +{
> +    FSTEST_DIR="$SCRATCH_MNT/fstest_test_dir"
> +    mkdir "$FSTEST_DIR"
> +
> +    procs=2
> +    while [ -f "$tmp.running" ]
> +      do
> +      src/fstest -m -p $FSTEST_DIR  -n $procs -f 4 > /dev/null 2>&1
> +    done
> +
> +    rm -rf $FSTEST_DIR/*
> +    rmdir $FSTEST_DIR
> +} &

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>